fix: fall back to original indentation keypress functionality #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: the `press()` function is used to fall back to the original
functionality of `<tab>` and `<S-tab>` when not in a list context. When
it does this, it appends before executing the original keypress,
modifying the fall back functionality.
Solution: Do not append before using the fall back functionality of
`<tab>` and `<S-tab>`.
This commit also refactors `handle_indent()`,
- removes unused variables
- removes `run_recalculate_after_delay()`, which appears to have
no effect
- reuses variables when possible (`cur_line`)
- renames variables for brevity (`in_list` and `at_line_end`)
Fixes gaoDean#79
|
@gaoDean I'd like a test run of this PR to see how it works for you |
|
Just installed this modified version. I'll (hopefully) post feedback here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the
press()function is used to fall back to the original functionality of<tab>and<S-tab>when not in a list context. When it does this, it appends before executing the original keypress, modifying the fall back functionality.Solution: Do not append before using the fall back functionality of
<tab>and<S-tab>.This commit also refactors
handle_indent(),- removes unused variables
- removes
run_recalculate_after_delay(), which appears to haveno effect
- reuses variables when possible (
cur_line)- renames variables for brevity (
in_listandat_line_end)Fixes #79