Improve startup time of pytest by optimising imports #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GernotMaier
added
the
Less than 15-min Pull Request Review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 82.22% 82.22%
=======================================
Files 41 41
Lines 6210 6210
=======================================
Hits 5106 5106
Misses 1104 1104 ☔ View full report in Codecov by Sentry. |
Comment on lines
+281
to
+282
| from simtools.corsika.corsika_histograms import CorsikaHistograms | ||
|
|
There was a problem hiding this comment.
shouldn't we add the pylint exception here or it doesnt matter for the test directory?
There was a problem hiding this comment.
This is not needed, as we do not run pylint over the test directory (we would get lots of complaints, e.g. from all the internal class functions we call in the test).
So no pylint comment required.
VictorBarbosaMartins
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #694
pytest on a simple test file can take >5s to start due to the time required for imports.
This PR optimises the import by moving the
simtools.corsika.corsika_histogramsimport into the corresponding pytest fixture (so it is called only when needed.This improves startup times for tests notably (at least on my laptop).