Trims output length to avoid hitting github 2Mb limitation #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
requestGitHubCheck
to respect the actual limitation of the platform.Should fix #142 . Loosely related to #169 .
Discussion
For now the PR only truncates the output without filtering as suggested in #142 and #169. If a test is failed in the said 65534 bytes, the mark will be set to
fail
. I'm a bit sceptical about the solution, but that's still a improvement over just failing for an unrelated github-limit reason.Of course, I'm open to other suggestions, such as implementing #169 fully if there is a concensus on it.
I'd gladly get some pointers for doing so, not being familiar with the ecosystem.
Thanks in advance 🙇
Checklist