-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Feature to test Unity Packages #164
Merged
Merged
Changes from all commits
Commits
Show all changes
115 commits
Select commit
Hold shift + click to select a range
db91528
(should fail) add jq install to docker image
trudeaua21 22f74eb
(might fail) remove rm rf call
trudeaua21 dff7de9
move things around to try to fix test
trudeaua21 c980404
Revert "(might fail) remove rm rf call"
trudeaua21 f9b9590
remove silent setting from docker test
trudeaua21 d9147cd
Fix failing test's Docker image
trudeaua21 1a54f84
Add new input and basic test
trudeaua21 b38a591
Add test package; start using jq cli
trudeaua21 d0b45c2
Use test package in test workflow
trudeaua21 1a9d374
Create temporary Unity Project and run tests
trudeaua21 6aa7a6f
Test removing jq install from Dockerfile
trudeaua21 635b692
Revert "Test removing jq install from Dockerfile"
trudeaua21 f5125f8
Remove mkdir call
trudeaua21 6da30c5
Merge branch 'main' of https://github.com/game-ci/unity-test-runner i…
trudeaua21 3b96124
Merge branch 'game-ci-main'
trudeaua21 19b81ef
remove duplicate command
trudeaua21 2a1d0bf
add packageMode option back in
trudeaua21 da456a3
build changes
trudeaua21 3f24118
check for apt-get before installing jq
trudeaua21 7a0e9c0
change apt-get version check message
trudeaua21 8e0b824
spelling and documentation fixes
trudeaua21 0555c18
add working example unity package with tests
trudeaua21 4f08cb5
add temp pwd call to help figure out absolute pathing
trudeaua21 798f66e
fix workflow package location
trudeaua21 39b63d9
add jq to add package to temp project packages
trudeaua21 f8810dc
try fixing jq calls
trudeaua21 bcf9542
clean up jq calls, fix variable expansion
trudeaua21 a023014
try renaming jq args
trudeaua21 f51a729
try using different arg syntax for jq
trudeaua21 e6dac78
try wrapping args in parentheses
trudeaua21 abfddf2
try using double quotes only
trudeaua21 feb610b
try changing up quoting
trudeaua21 f53e41c
try properly using string interpolation
trudeaua21 f8e2231
try removing colon
trudeaua21 592e959
add string interpolation to key
trudeaua21 16c034f
omit double quotes from jq call to retrieve package name
trudeaua21 4312493
clean up logging
trudeaua21 c0bb008
add rest of workflow tests
trudeaua21 9eabe57
Revert "add rest of workflow tests"
trudeaua21 963f4e5
add play mode test without cache
trudeaua21 522658a
add package mode all mode workflow step
trudeaua21 9f30148
add consecutive ppackage mode workflow step
trudeaua21 8938275
add package mode "like in the readme" test
trudeaua21 2742382
fix workflow syntax error
trudeaua21 ab1facd
try to fix syntax error again
trudeaua21 3a919c6
use correct folder
trudeaua21 9c6589d
*hopefully actually* use correct package path
trudeaua21 0dfba9d
try adding caching to "readme" test
trudeaua21 510d7f0
remove caching/mentions of caching from package mode tests
trudeaua21 5723ea9
fix artifacts paths
trudeaua21 980e6b7
fix artifacts pathing and names
trudeaua21 2011208
fix combined artifacts for package mode
trudeaua21 99e2333
clean up documentation and exit code
trudeaua21 3620484
clarify allowed docker images for packageMode
trudeaua21 7a6805e
update README to mention Unity packages
trudeaua21 a04ac83
move package name validation to TS part of action
trudeaua21 c984699
Merge branch 'game-ci:main' into main
trudeaua21 27b9700
Merge branch 'main' of https://github.com/trudeaua21/unity-test-runner
trudeaua21 7f6ed5d
improve logging for temp project creation failure
trudeaua21 140183d
make husky hook executable
trudeaua21 441ad80
add error for missing tests folder
trudeaua21 7338fb9
merge main and fix no-abbreviation eslint error
trudeaua21 acea6b6
update docs to reflect unsupported packages
trudeaua21 bd35ac8
remove jq install
trudeaua21 e3bac04
Revert "remove jq install"
trudeaua21 95722dc
TEMP log image in use
trudeaua21 2fe4078
Revert "TEMP log image in use"
trudeaua21 14f2743
Revert "Revert "remove jq install""
trudeaua21 db9c07d
TEMP list installed packages
trudeaua21 793451a
Merge remote-tracking branch 'upstream/main'
trudeaua21 d8ac8df
Revert "TEMP list installed packages"
trudeaua21 c942fae
TEMP log project's manifest
trudeaua21 1580d4c
add code coverage package to generated project
trudeaua21 c927250
remove temp project manifest log
trudeaua21 d0104eb
add coverage to package mode tests
trudeaua21 7eda874
update name of package coverage steps
trudeaua21 4b2c030
add codecoverage dependency to test package
trudeaua21 ebd7a75
Revert "add codecoverage dependency to test package"
trudeaua21 b47553a
add assembly filters for coverage
trudeaua21 411ec51
TEMP console log project folder
trudeaua21 139a8b1
Revert "TEMP console log project folder"
trudeaua21 b20d994
add logic to copy package to folder without activation file
trudeaua21 580c9c1
fix false positive activation file detection
trudeaua21 acb975b
fix improper bash "if" formatting
trudeaua21 4f12d83
TEMP remove conditional for package copying
trudeaua21 397d1ba
Revert "TEMP remove conditional for package copying"
trudeaua21 4895ba9
Revert "fix improper bash "if" formatting"
trudeaua21 0e7c6f9
Revert "fix false positive activation file detection"
trudeaua21 76e4fa8
Revert "add logic to copy package to folder without activation file"
trudeaua21 0061df2
merge main
trudeaua21 8bed000
run yarn build
trudeaua21 dbb5a4c
move package mode check lower in the file
trudeaua21 bd60170
throw error if unity version is auto in package mode
trudeaua21 9d2f6b8
fix unity version error wording
trudeaua21 6d87a92
try deleting activate license file
trudeaua21 1f56db9
try logging hidden package files
trudeaua21 9169a99
try deleting all non-package files
trudeaua21 c9301a2
fix license activation files deletion
trudeaua21 f75f0eb
scrap file removals and print dir permissions
trudeaua21 4025223
log permissions for package folder
trudeaua21 ffb0014
Merge in changes
trudeaua-vividream-software 8ac6a10
Add packageMode inputs to main
trudeaua-vividream-software 1afbd6b
fix fs mocks and run yarn build
trudeaua-vividream-software 0df3ab6
fix documentation and add error message for missing jq
trudeaua-vividream-software fb62d36
add clarification on package mode caveats
trudeaua-vividream-software 1cba302
fix line endings problem (?)
trudeaua-vividream-software c0e9729
Revert "fix line endings problem (?)"
trudeaua-vividream-software ed7bbc6
Revert "add clarification on package mode caveats"
trudeaua-vividream-software 22d5420
Revert "fix documentation and add error message for missing jq"
trudeaua-vividream-software edae3e7
Redo the input docs fixes
trudeaua-vividream-software 32aa19c
Redo the jq presence test
trudeaua-vividream-software a1b7bb8
update readme to indicate package mode caveats
trudeaua-vividream-software aed7ecd
fix wording on coverageOptions
trudeaua-vividream-software ad8643f
one more wording fix on coverageOptions
trudeaua-vividream-software 70eaa73
move sample package to example.com domain
trudeaua-vividream-software File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to detect that a Unity Package is tested instead of the regular case?
Perhaps we can just smoothen this over inside the auto strategy?
Perhaps something like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a thrown error for this case on line 109 of
input.ts
:Does this address the problem or no? Not totally sure if this is what you were going for.
I'd like to add an "auto" strategy for package mode, but not until after the base feature is released, if possible.