Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: phase out old workflow tags #141

Merged
merged 2 commits into from
Jan 22, 2022
Merged

Conversation

webbertakken
Copy link
Member

@webbertakken webbertakken commented Jan 22, 2022

Changes

  • For base and hub images we build for all base platforms at the same time, tags are shared
  • For legacy and specific version editor workflows we keep them separated, so that we can manage workflows for different baseOses separately.

Checklist

  • Read the contribution guide and accept the code of conduct
  • Readme (updated or not needed)

@github-actions
Copy link

Cat Gif

@webbertakken
Copy link
Member Author

Found a potential blocker for windows builds:

image

@AndrewKahr these builds ran before right?

@AndrewKahr
Copy link
Member

I think this might be the first time the windows ones were attempted. I thought they would run with the original PR but it appears that was not the case. I believe it's complaining about using the registry container for the builds. I might be able to just remove it and have it build locally.

@AndrewKahr
Copy link
Member

@webbertakken Is there a specific reason for using a local registry container vs just building locally on the runner?

@webbertakken
Copy link
Member Author

It looks like windows images are not supported at all?

Hopefully there is some kind of workaround - I think we don't necessarily need GitHub support, just the build to work would go a long way.

@AndrewKahr
Copy link
Member

Yea that's what I've been seeing. I'm gonna put up a commit that removes reliance on the container registry and just have it build locally on the runner. I think the main purpose of the PR workflow is to make sure it builds so I don't see an issue with this as a workaround.

@webbertakken
Copy link
Member Author

Ok. In the meantime I'm going to merge this. Could you reference this PR in your commit please?

@webbertakken webbertakken merged commit fb51544 into main Jan 22, 2022
@webbertakken webbertakken deleted the add-generic-triggers-to-win branch January 22, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants