Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with saving blocks using the latest Gutenberg plugin (v 5.9) #122

Closed
Nick-Fiasco opened this issue Jun 12, 2019 · 6 comments
Closed

Comments

@Nick-Fiasco
Copy link

Hi,

I've experienced some issues with saving Stackable blocks with the latest version of the Gutenberg plugin. Version 5.9 which was launched today. (I have it installed in order to make use of the latest features added in the Gutenberg plugin that aren't yet in Core).

Scenario I have been testing
I have tried creating a Stackable Container block with just one Heading and one Paragraph block inside it. With the Gutenberg plugin installed the nested blocks do not save and therefore do not render on the frontend. You can see them in the Editor, but no nested blocks on the frontend. Just the container block itself. I have also tested with other nested core blocks like Image, same result.

If I disable the Gutenberg plugin then re-save the page it all works fine.

Are there any known bugs with the latest Gutenberg plugin? Appreciate it only publicly launched today!

@grouse9000
Copy link

grouse9000 commented Jun 13, 2019

Yes I was about to report something similar, when I saw this post. I use Stackable to add buttons to my website in Wordpress. I can see the buttons in the editor, but when I preview only a dot (must be the container like you said), then I go back to the editor, and cannot see the buttons or even the block anymore. All old pages and posts are fine, it is only new editing that is not working.

@bfintal
Copy link
Contributor

bfintal commented Jun 13, 2019

Hey @Nick-Fiasco and @grouse9000

Apparently in 5.9 they deprecated a few components which were moved to different packages which resulted in undefined function errors.

The RichText component was affected along with other components used from the @wordpress/editor package. Will have to move them over to the new one while supporting the old calls.

@Nick-Fiasco
Copy link
Author

Yeah. I did read about some more deprecations alongside the other updates and fixes they did with v5.9.

I am currently only using Stackable to test out some things before using it in live sites, so it doesn't affect me much, but might affect other users who are using it on live sites that have been updated.

Hence why I thought I should flag it up.

@bfintal
Copy link
Contributor

bfintal commented Jun 13, 2019

@Nick-Fiasco Thanks for pointing it out. Contemplating the best way to handle it for things to be backward compatible for users, let me know if you have a suggestion how. I'm thinking that wp.blockEditor.RichText should be used if available instead of wp.editor.RichText. Not sure whether it's possible to do that in the externals file

Since the move to wp.blockEditor was merged back in March 8 (WordPress/gutenberg#14112), so I'm guessing around Gutenberg v5.5. Not sure what WordPress version that was out. Depending on how early that is, maybe we can just move the references to wp.blockEditor.RichText to easily fix the problem.

@bfintal
Copy link
Contributor

bfintal commented Jun 14, 2019

@Nick-Fiasco & @grouse9000 v1.15.5 is now out with the fixes for Gutenberg 5.9 :)

@Nick-Fiasco
Copy link
Author

Nick-Fiasco commented Jun 14, 2019

Ah great! Thanks very much for the quick fix.

bfintal added a commit that referenced this issue Jun 14, 2019
…ordpress/editor` to `@wordpress/block-editor` Closes #122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants