fix: remove waitForExist from waitForDisplayed implementation (cloudi…

…nary#251) * fix: remove waitForExist from waitForDisplayed implementation
galoniz · Oct 3, 2021 · b36deb9 · b36deb9
1 parent bfc341a
commit b36deb9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/src/commons/BrowserUtils.ts b/src/commons/BrowserUtils.ts
@@ -299,9 +299,6 @@ export namespace BrowserUtils {
    */
   export function waitForDisplayed(selector: string, options?: WaitForOptions): void {
     Reporter.debug(`Wait for an element to be visible '${selector}'`);
-    if (options?.reverse) {
-      waitForExist(selector, options);
-    }
     tryBlock(
       () => $(selector).waitForDisplayed({ ...{ timeout: DEFAULT_TIME_OUT }, ...options }),
       `Element not visible '${selector}'`

diff --git a/src/test/specs/ExpectNumberOfElementsSpec.ts b/src/test/specs/ExpectNumberOfElementsSpec.ts
@@ -24,7 +24,7 @@ describeCommon('waitForNumberOfElements', () => {
     expect(() => BrowserUtils.waitForNumberOfElements(`${SELECTION_BOX}${LIST_ITEM}`, 0))
       .to.throw(Error)
       .with.property('message')
-      .contains(`still existing`);
+      .contains(`still displayed `);
   });
 
   it("Expect number of elements, element doesn't exists", () => {

diff --git a/src/test/specs/NotVisibleSpec.ts b/src/test/specs/NotVisibleSpec.ts
@@ -14,14 +14,11 @@ describeCommon('waitForDisplayed - reverse: true', () => {
     expect(() => BrowserUtils.waitForDisplayed(VISIBLE_ELEMENT_SELECTOR, { reverse: true }))
       .to.throw(Error)
       .with.property('message')
-      .contains(' still existing');
+      .contains(' still displayed ');
   });
 
   it('notDisplayed but exist element ', () => {
-    expect(() => BrowserUtils.waitForDisplayed(NOT_VISIBLE_ELEMENT_SELECTOR, { reverse: true }))
-      .to.throw(Error)
-      .with.property('message')
-      .contains('still existing');
+    expect(() => BrowserUtils.waitForDisplayed(NOT_VISIBLE_ELEMENT_SELECTOR, { reverse: true })).to.not.throw(Error);
   });
 
   it('not exist element ', () => {