-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screens/social profile screen #56
base: examples
Are you sure you want to change the base?
Conversation
Related to #31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
Nice! This looks awesome! Could you expand on the issues you encountered?
You've done a great job! I'm glad you found it easy and cool to work with Galio ❤️.
When I first opened your screen's file I noticed there are 54 eslint errors, could you fix them?
Thanks,
Alin 🤙🏽
@samcyn a quick check for lint is to run |
update: All linting errors have been fixed. Thanks @hetmann and @palingheorghe for the review. |
Hi one more change. I added COLOR_DARK_GREY='#444444' as suggested by @hetmann. And that should be all for now. Thanks guys. |
Social Profile Screen
I am done with this screen and would like some reviews on the work done. I enjoyed using Galio a lot. If not for the issues I had picking out some detailed measurements from the designs I would be done in a day or so. Well check out what I got and let me know what you think.
Regards.