Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to latest version of ncbi-egapx #834

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

richard-burhans
Copy link
Contributor

@richard-burhans richard-burhans commented Sep 10, 2024

TODO: Please replace this header with a description of your pull request.

Installation sequence for tool-installers

  • Test using @galaxybot test this
  • Inspect CI output for expected changes
  • Deploy using @galaxybot deploy this if test install was successful
  • Merge this PR

@richard-burhans richard-burhans requested a review from a team as a code owner September 10, 2024 23:20
@richard-burhans

This comment was marked as resolved.

1 similar comment
@martenson
Copy link
Member

@galaxybot test this

@martenson
Copy link
Member

shed_tools diff is empty, something is wrong

@mvdbeek
Copy link
Member

mvdbeek commented Sep 11, 2024

Update without version bump, you can tell by 7c72d5c7e449 being modified, which is not the new revision.

@martenson
Copy link
Member

except there should be one richard-burhans/galaxytools@f47ba0b

@mvdbeek
Copy link
Member

mvdbeek commented Sep 11, 2024

https://github.com/richard-burhans/galaxytools/actions/runs/10799704747/job/29956466322

@mvdbeek
Copy link
Member

mvdbeek commented Sep 11, 2024

(Missing the all_fasta.loc.sample file)

@martenson
Copy link
Member

martenson commented Sep 11, 2024

the subsequent MTS deploy CI ran fine (https://github.com/richard-burhans/galaxytools/actions/runs/10800498795) and the MTS version on tip bf80a7ed8595 has the increased version and the .loc.sample file

@mvdbeek
Copy link
Member

mvdbeek commented Sep 11, 2024

The repo files are missing all_fasta.loc.sample, I don't think this can work. I don't know why the tool shed has accepted this ?

@martenson
Copy link
Member

The tip has the .loc.sample but the previous MTS revision does not, and between those two there is no version bump. So version bump should ideally fix this.

Screenshot 2024-09-11 at 1 11 28 PM

martenson added a commit to martenson/galaxytools-rico that referenced this pull request Sep 11, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Sep 11, 2024

I always thought they need to be in the same directory?

@martenson
Copy link
Member

I don't think that is mandatory or a standard
Screenshot 2024-09-11 at 2 55 14 PM

richard-burhans pushed a commit to richard-burhans/galaxytools that referenced this pull request Sep 11, 2024
@richard-burhans
Copy link
Contributor Author

FYI: I had accepted a pull request from @fubar2 (Ross Lazarus), but I didn't realize there was a new select param using from_data_table. I never created a tool_data_table_conf.xml.sample file and neither planemo lint nor planemo shed_lint noticed this error. I pushed to my fork, and the github actions were able to push the broken version to the toolshed. I realized this last night and tried pushing out an update with an updated version.

@martenson
Copy link
Member

@galaxybot test this

@martenson
Copy link
Member

@galaxybot deploy this

@mvdbeek mvdbeek merged commit 6f6a78c into galaxyproject:master Sep 12, 2024
1 check passed
@richard-burhans richard-burhans deleted the update-ncbi-egapx branch October 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants