Ignore failure to download output datasets #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we raise an exception here we won't get a full report with what really is the issue. Also uses output_to_cwl_json for hdas, since it produces the same output.
mvdbeek
force-pushed
the
improve_error_reporting_failed_requests
branch
from
34eb422 to
e22ddd3
Compare
jmchilton
reviewed
Jul 12, 2021
| # We don't want this to break the rest of the test report. | ||
| # Should probably find a way to propagate this back into the report. | ||
| ctx.vlog(f"Failed to download history content at URL {url}, exception: {e}") | ||
| return |
There was a problem hiding this comment.
The job needs to fail right? You cannot run test assertions on this.
There was a problem hiding this comment.
If we're reaching this point the job has already failed (most likely), and the test assertions would run on an empty file, so they should still produce the failure. Checkout line 380 and 363, where we're also skipping outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we raise an exception here we won't get a full report with what
really is the issue.
Also uses output_to_cwl_json for hdas, since it produces the same
output.
Should produce a more meaningful test report for galaxyproject/iwc#47