Fix stopping of gx-it-proxy #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! This has been an annoyance of mine, too -- I thought I even tried stopasgroup, too, but I might have changed too many variables at once :) |
|
Cool :) Now I'm wondering how to apply this fix on my instance 🤔 is there a gravity release planned anytime soon? |
|
We can make a release and update the dependency in the 22.05 branch, no problem. |
|
There's only one supervisord template in Gravity 1.x, so in merging this forward, we could set this conditionally per service, but I suspect there'd be no harm in setting it on all the managed services. |
|
Merged forward in 3e9913d. |
|
Released in Gravity 0.13.6 and the update to Galaxy is in galaxyproject/galaxy#15122. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #90, tested locally on 22.05