Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to JobRunnerMapper and related code #19115

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Nov 7, 2024

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo
Copy link
Member Author

nsoranzo commented Nov 7, 2024

Integration test failure unrelated.

@nsoranzo nsoranzo requested a review from a team November 11, 2024 11:33
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thank you!

@jdavcs jdavcs merged commit 02a1d6a into galaxyproject:dev Nov 12, 2024
53 of 54 checks passed
@nsoranzo nsoranzo deleted the type_annot_JobRunnerMapper branch November 12, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants