-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XML based vtk
datatype
#19104
base: dev
Are you sure you want to change the base?
Add XML based vtk
datatype
#19104
Conversation
Is it possible to reduce the test data size to a bare minimum? Thanks a lot @tStehling! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tStehling. Really good start.
The implementation might fit better to https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/datatypes/constructive_solid_geometry.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this TODO:
TODO: only legacy formats are currently supported and support for XML formats |
Would be great if we would have also tests for set_meta
. Maybe analogous to:
def test_qzv_set_meta(): |
The datatype needs to be added here as well https://github.com/galaxyproject/galaxy/blob/8f22c937894c718f513401279a55bddf40ba79cb/lib/galaxy/config/sample/datatypes_conf.xml.sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a unit test along the lines of
def test_qza_set_meta(): |
7457cd4
to
887b1aa
Compare
Added the datatype VTK Unstructured Grid / VTU so the VTU files can be processed by Galaxy tools.
Also added test data for the sniff method.
How to test the changes?
(Select all options that apply)
License