Add workflow to update PR title based on target branch version #18835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsoranzo
reviewed
Sep 17, 2024
nsoranzo
reviewed
Sep 17, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Sep 17, 2024
nsoranzo
reviewed
Sep 17, 2024
|
This is going to be very helpful, thanks! |
nsoranzo
reviewed
Oct 11, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Oct 11, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
approved these changes
Oct 14, 2024
|
Thanks @arash77 ! |
|
This PR was merged without a "kind/" label, please correct. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+19
to
+27
| run: | | ||
| PR_NUMBER=${{ github.event.pull_request.number }} | ||
| TARGET_BRANCH="${{ github.base_ref }}" | ||
| PR_TITLE="${{ github.event.pull_request.title }}" | ||
| VERSION=$(echo $TARGET_BRANCH | grep -oP '\d+\.\d+') | ||
| if [[ -n "$VERSION" && ! "$PR_TITLE" =~ ^\[$VERSION\] ]]; then | ||
| NEW_TITLE="[$VERSION] $PR_TITLE" | ||
| gh pr edit $PR_NUMBER --title "$NEW_TITLE" | ||
| fi |
Check failure
Code scanning / CodeQL
Expression injection in Actions Critical
There was a problem hiding this comment.
Should we sanitize PR_TITLE to prevent injection here or is it unnecessary?
There was a problem hiding this comment.
Not sanitize it, but define it in env: : #18987
|
@arash77 Should we backport (the latest version of) this workflow to, let's say, release_24.0 ? Otherwise it's not run on the PRs where it's actually useful. |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add a GitHub workflow to add the version number to the PR title if the target branch is a release branch.
How to test the changes?
(Select all options that apply)
License