-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sample Celery result_backend in config #17949
Merged
jdavcs
merged 8 commits into
galaxyproject:dev
from
davelopez:replace_default_celery_backend
Apr 11, 2024
Merged
Replace sample Celery result_backend in config #17949
jdavcs
merged 8 commits into
galaxyproject:dev
from
davelopez:replace_default_celery_backend
Apr 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdavcs
reviewed
Apr 9, 2024
All I can add here is that I used sqlite on my test instance and it worked. |
davelopez
force-pushed
the
replace_default_celery_backend
branch
from
April 10, 2024 13:24
f009b75
to
b87443b
Compare
davelopez
force-pushed
the
replace_default_celery_backend
branch
from
April 10, 2024 13:27
b87443b
to
ac52618
Compare
jdavcs
reviewed
Apr 10, 2024
jdavcs
reviewed
Apr 10, 2024
Co-authored-by: John Davis <[email protected]>
Co-authored-by: Nicola Soranzo <[email protected]>
jdavcs
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thank you for all the edits!
Regenerate the config, and it's good to go.
nsoranzo
reviewed
Apr 10, 2024
This will keep the values in the sample config.
nsoranzo
reviewed
Apr 10, 2024
Co-authored-by: Nicola Soranzo <[email protected]>
Test failures unrelated :) |
Thanks a lot @davelopez for adding docs and all this for celery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17881
Fixes #17878
It just replaces the default Celery
result_backend
fromredis
to an SQLite database so it should "work out of the box" with a development instance. Production instances should change to something more robust as hinted in the documentation.How to test the changes?
(Select all options that apply)
License