Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sample Celery result_backend in config #17949

Merged
merged 8 commits into from
Apr 11, 2024

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Apr 9, 2024

Closes #17881
Fixes #17878

It just replaces the default Celery result_backend from redis to an SQLite database so it should "work out of the box" with a development instance. Production instances should change to something more robust as hinted in the documentation.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 24.1 milestone Apr 9, 2024
@bernt-matthias
Copy link
Contributor

All I can add here is that I used sqlite on my test instance and it worked.

@davelopez davelopez force-pushed the replace_default_celery_backend branch from f009b75 to b87443b Compare April 10, 2024 13:24
@davelopez davelopez force-pushed the replace_default_celery_backend branch from b87443b to ac52618 Compare April 10, 2024 13:27
Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for all the edits!

Regenerate the config, and it's good to go.

This will keep the values in the sample config.
@davelopez davelopez marked this pull request as draft April 11, 2024 07:17
@davelopez davelopez marked this pull request as ready for review April 11, 2024 07:22
@davelopez
Copy link
Contributor Author

Test failures unrelated :)

@jdavcs jdavcs merged commit 58490e5 into galaxyproject:dev Apr 11, 2024
52 of 54 checks passed
@bernt-matthias
Copy link
Contributor

Thanks a lot @davelopez for adding docs and all this for celery.

@davelopez davelopez deleted the replace_default_celery_backend branch April 11, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable sqlalchemy as celery result backend if no result backend is set up /api/tasks/TASK_ID/state gives 500
4 participants