Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the client to make use of schema models for the users API #16608

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

heisner-tillman
Copy link
Contributor

This is an extension of #16341.
The goal is to update the client so that it makes use of the newly created schema models from the referenced pull request.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. I do not know how to test this manually

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@heisner-tillman heisner-tillman marked this pull request as draft August 29, 2023 09:15
@github-actions github-actions bot added this to the 23.2 milestone Aug 29, 2023
@bgruening bgruening requested a review from itisAliRH August 29, 2023 09:47
@mvdbeek
Copy link
Member

mvdbeek commented Aug 29, 2023

The errors you're seeing there are very nice, and I think highlight a real problem when the current user is anonymous. You should be able to narrow the type by checking for properties that are only present for non-anonymous users.

@jmchilton
Copy link
Member

Love this - I would say dropping rethrowSimple will mean that the standardized error messages produced on the backend are going to be suppressed and not included to upstream components so I'd prefer to see hooking into the existing error handling stuff but I understand the desire for simplicity also.

@mvdbeek
Copy link
Member

mvdbeek commented Aug 29, 2023

Fetcher has a rethrowSimple middleware,

const rethrowSimpleMiddleware: Middleware = async (url, init, next) => {
so this isn't needed

@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants