Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt quotas tests to use JSON payload #12417

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

davelopez
Copy link
Contributor

#11315 was a bit old and didn't have the latest changes to force JSON payload introduced in #12152 so some of these tests will start failing on dev.

How to test the changes?

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@davelopez davelopez marked this pull request as draft September 8, 2021 16:27
@davelopez davelopez marked this pull request as ready for review September 8, 2021 16:34
@davelopez davelopez added area/testing/api area/testing/integration kind/refactoring cleanup or refactoring of existing code, no functional changes labels Sep 8, 2021
@github-actions github-actions bot added this to the 21.09 milestone Sep 8, 2021
@dannon
Copy link
Member

dannon commented Sep 8, 2021

@davelopez Thanks for the quick fix, good catch!

This selenium test has been flaky; I'm going to take a quick look at it to see what's going on, but it's not related to this work.
FAILED lib/galaxy_test/selenium/test_workflow_editor.py::WorkflowEditorTestCase::test_optional_select_data_field

@mvdbeek This sounds familiar -- didn't you add a debounce to something to handle this case elsewhere? The last letter of the entered string isn't getting detected in that test, sporadically. I dug up the history and tried something new in #12423

@dannon dannon merged commit fcdd76e into galaxyproject:dev Sep 8, 2021
@davelopez davelopez deleted the fix_quotas_tests branch September 8, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing/api area/testing/integration kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants