Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the User-Agent when creating a GalaxyClient #318

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

blankenberg
Copy link
Member

No description provided.

@nsoranzo
Copy link
Member

@blankenberg Thanks for the PR! Can I ask what's the use case? A particular issue this is meant to solve?

Base automatically changed from master to main January 16, 2021 17:50
@hexylena
Copy link
Member

hexylena commented Jul 4, 2024

Came to file the associated bug report, only to discover this PR! Thanks @blankenberg !

I can provide a use case: identifying who i am in server access.

When I decide to go hammer the galaxy or toolshed API, it's generally courteous to self-identify and provide e.g. a github url so sysadmins know where to submit bug reports if they're experiencing undue load from my client. Nice bots share who they are, so, it's easier to communicate with their developers.

In some of my other non-bioblend scripts I send a project name/version/github URL in the user-agent, so I'm fully in support of this and would love to see it rebased and available!

@nsoranzo
Copy link
Member

nsoranzo commented Jul 4, 2024

Thanks @hexylena , I've rebased the PR, can you have a look?

@nsoranzo nsoranzo merged commit 5f1dea0 into galaxyproject:main Jul 9, 2024
20 checks passed
@hexylena
Copy link
Member

Apologies, missed the ping. Yes, this looks great.

@nsoranzo
Copy link
Member

Apologies, missed the ping. Yes, this looks great.

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants