Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support defining a maximum node version for a given platform #184

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Mar 9, 2023

As discussed in #183.

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@natefoo
Copy link
Member Author

natefoo commented Mar 10, 2023

@jdavcs thanks for the review! I've reproduced the remaining error locally and the log contains:

INFO:alembic.runtime.migration:Context impl SQLiteImpl.
INFO:alembic.runtime.migration:Will assume non-transactional DDL.
Traceback (most recent call last):
  File "/srv/galaxy/server/lib/galaxy/webapps/galaxy/buildapp.py", line 59, in app_pair
    app = galaxy.app.UniverseApplication(global_conf=global_conf, **kwargs)
  File "/srv/galaxy/server/lib/galaxy/app.py", line 600, in __init__
    super().__init__(fsmon=True, **kwargs)
  File "/srv/galaxy/server/lib/galaxy/app.py", line 495, in __init__
    super().__init__(**kwargs)
  File "/srv/galaxy/server/lib/galaxy/app.py", line 244, in __init__
    self._configure_models(check_migrate_databases=self.config.check_migrate_databases, config_file=config_file)
  File "/srv/galaxy/server/lib/galaxy/app.py", line 429, in _configure_models
    self._verify_databases(engine, install_engine, combined_install_database)
  File "/srv/galaxy/server/lib/galaxy/app.py", line 453, in _verify_databases
    verify_databases(
  File "/srv/galaxy/server/lib/galaxy/model/migrations/__init__.py", line 157, in verify_databases
    gxy_verifier.run()
  File "/srv/galaxy/server/lib/galaxy/model/migrations/__init__.py", line 213, in run
    self._handle_nonempty_database()
  File "/srv/galaxy/server/lib/galaxy/model/migrations/__init__.py", line 238, in _handle_nonempty_database
    self._handle_with_alembic()
  File "/srv/galaxy/server/lib/galaxy/model/migrations/__init__.py", line 269, in _handle_with_alembic
    raise RevisionNotFoundError(model)
galaxy.model.migrations.exceptions.RevisionNotFoundError: The database has an alembic version table, but that table does not contain a revision for the galaxy model

But I have no idea why this only occurs on centos7.

@jdavcs
Copy link
Member

jdavcs commented Mar 10, 2023

@natefoo How did you reproduce it locally? (i.e., did you start galaxy? also, what's your database setup - I assume at least one db is sqlite?) From what I saw in the molecule output, I guessed it was a gravity restart one-of error - did I misread that log? Or was the migrations error visible only locally?

@natefoo
Copy link
Member Author

natefoo commented Mar 10, 2023

It was only visible locally, so I can't say for sure it's the same issue being encountered here in the GHA. I used a local CentOS 7 VM and ran the role against that and it failed at the same place with the same error, but I was only able to get the underlying error from the log file in the VM. This is with a SQLite db, same as the test.

@jdavcs
Copy link
Member

jdavcs commented Mar 10, 2023

Apparently, related to galaxyproject/galaxy#15765

@natefoo natefoo force-pushed the max-node-version branch 2 times, most recently from bf8a8b8 to e031afa Compare March 13, 2023 15:03
@natefoo natefoo merged commit f7b6e98 into main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants