Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to polkadot-v0.9.29 #571

Merged
merged 47 commits into from
Nov 3, 2022
Merged

chore: upgrade to polkadot-v0.9.29 #571

merged 47 commits into from
Nov 3, 2022

Conversation

enthusiastmartin
Copy link
Contributor

@enthusiastmartin enthusiastmartin commented Oct 31, 2022 •
edited
Loading

Changes:

  • Weight type changed from u64 to a struct.
  • math lib contains changes in lbp math (rounding fixed by colin) and improved pow accuracy
  • removed Exchange pallet
  • removed LBP and XYK rpcs
  • Weights updated

@github-actions
Copy link

github-actions bot commented Oct 31, 2022 •
edited
Loading

Crate versions that have been updated:

  • runtime-integration-tests: v0.8.0 -> v0.8.1
  • parachain-runtime-mock: v0.1.0 -> v0.1.1
  • basilisk: v7.1.0 -> v8.0.0
  • pallet-duster: v3.1.4 -> v3.1.5
  • pallet-lbp: v4.5.0 -> v4.6.0
  • pallet-marketplace: v4.0.1 -> v5.0.0
  • pallet-xyk: v6.0.0 -> v6.0.1
  • pallet-xyk-liquidity-mining: v1.0.1 -> v1.0.2
  • pallet-xyk-liquidity-mining-benchmarking: v1.0.0 -> v1.0.1
  • primitives: v6.3.4 -> v6.3.5
  • basilisk-runtime: v80.0.0 -> v81.0.0
  • common-runtime: v2.2.3 -> v2.2.4
  • testing-basilisk-runtime: v80.0.0 -> v81.0.0

Runtime version has been increased.

dmoka and others added 25 commits October 31, 2022 16:45
@dmoka
fix lbp integration tests
d51f3f1
@dmoka
formatting
d911bdd
@dmoka
fixed lbp unit tests - event ordering and amount changes due to bette…
a215020 
…r precision
@dmoka
fix missing invert tests
79beadb
@Roznovjak
update marketplace migration
a983bd0
@enthusiastmartin
fix xyk-lm migration
bdca9f0
@enthusiastmartin
use patch polkadot
3fab7ba
@enthusiastmartin
remove exchange pallet
d79c1c8
@enthusiastmartin
remove redundant into
a687ea5
@enthusiastmartin
happy clippy happy life
dab076b
@enthusiastmartin
Merge branch 'master' into polkadot-v0.9.29
af1615c
@enthusiastmartin
remove offchain duster unused pallet
1c7b837
@enthusiastmartin
bump versions
9b7ee14
@Roznovjak
add missing check for max_royalty to migration
ffac16b
@Roznovjak
bump crate version
91240aa
@enthusiastmartin
remove try runtime from testing runtime
07ea4b6
@enthusiastmartin
add try-runtime features to pallets
79a5670
@enthusiastmartin
fix build with try-runtime features
dda6613
@enthusiastmartin
Merge branch 'master' into polkadot-v0.9.29
68df9b6
@enthusiastmartin
update integration tests new package to 29
d3edbda
@enthusiastmartin
formatting
8e79617
@enthusiastmartin
formatting strikes back
ccb6c89
@enthusiastmartin
package version police warning
a683320
@enthusiastmartin
fix parachain mock runtime weights
eea440d
@enthusiastmartin
fix lbp benchmark tests
00288dc
@codecov
Copy link

codecov bot commented Nov 2, 2022 •
edited
Loading

Codecov Report

Base: 80.04% // Head: 81.11% // Increases project coverage by +1.07% 🎉

Coverage data is based on head (050809f) compared to base (1a99f62).
Patch coverage: 3.94% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   80.04%   81.11%   +1.07%     
==========================================
  Files          26       18       -8     
  Lines        2636     1949     -687     
==========================================
- Hits         2110     1581     -529     
+ Misses        526      368     -158
Impacted Files Coverage Δ
pallets/marketplace/src/lib.rs 91.83% <ø> (ø)
pallets/marketplace/src/migration.rs 0.00% <0.00%> (ø)
pallets/xyk-liquidity-mining/src/lib.rs 84.89% <ø> (ø)
pallets/xyk-liquidity-mining/src/migration.rs 36.36% <ø> (ø)
primitives/src/constants.rs 0.00% <ø> (ø)
...ntegration-tests/parachain-runtime-mock/src/lib.rs 62.79% <50.00%> (-0.63%) ⬇️
pallets/lbp/src/benchmarking.rs 98.64% <100.00%> (ø)
pallets/xyk/src/lib.rs 84.65% <0.00%> (-1.33%) ⬇️
...llets/xyk-liquidity-mining/benchmarking/src/lib.rs 92.34% <0.00%> (+0.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Roznovjak
Roznovjak approved these changes Nov 2, 2022
View reviewed changes
integration-tests/src/fees.rs Outdated Show resolved Hide resolved
node/Cargo.toml Outdated Show resolved Hide resolved
@mrq1911
Merge branch 'feat/marketplace_migration' into polkadot-v0.9.29
5036501 
# Conflicts:
#	pallets/marketplace/Cargo.toml
#	pallets/marketplace/src/migration.rs
@mrq1911
lock
24bfd86
@mrq1911
rich knows
a1d4fb4
@mrq1911
merge fix
4524bd7
@mrq1911
fmt
ef05714
mrq1911
mrq1911 reviewed Nov 3, 2022
View reviewed changes
runtime/basilisk/src/lib.rs Outdated
@@ -1045,7 +1032,7 @@ pub type Executive = frame_executive::Executive<
Block,
frame_system::ChainContext<Runtime>,
Runtime,
AllPalletsReversedWithSystemFirst,
AllPalletsWithSystem,
Copy link
Member

@mrq1911 mrq1911 Nov 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enthusiastmartin why did this change? no change in construct_runtime! is required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enthusiastmartin why did this change? no change in construct_runtime! is required?

AllPalletsReversedWithSystemFirst is deprecated in favor of this.

Copy link
Member

@mrq1911 mrq1911 Nov 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am aware of it, but it also changes orders in which are pallets loaded, see
paritytech/substrate#10043

@mrq1911 mrq1911 merged commit c2093c9 into master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrq1911 mrq1911 mrq1911 approved these changes

@Roznovjak Roznovjak Roznovjak approved these changes

@dmoka dmoka Awaiting requested review from dmoka

@martinfridrich martinfridrich Awaiting requested review from martinfridrich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@enthusiastmartin @mrq1911 @Roznovjak @dmoka @martinfridrich