This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(etherscan): add caching #935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Feb 20, 2022
ethers-etherscan/src/contract.rs
Outdated
Comment on lines
239
to
242
| let path = cache.join("abis").join(format!("{:?}.json", address)); | ||
| let reader = std::io::BufReader::new(std::fs::File::create(path)?); | ||
| let abi = serde_json::from_reader(reader)?; | ||
| return Ok(abi) |
There was a problem hiding this comment.
should we instead continue with the request if this results in an error, like file does not exist?
ethers-etherscan/src/lib.rs
Outdated
Comment on lines
39
to
41
| let mut this = Self::new(chain, api_key)?; | ||
| this.cache = cache; | ||
| Ok(this) |
There was a problem hiding this comment.
alternatively call Self::new_cached(chain, api_key, None) from Self::new
ethers-etherscan/src/contract.rs
Outdated
Comment on lines
267
to
270
| let path = cache.join("sources").join(format!("{:?}.json", address)); | ||
| let reader = std::io::BufReader::new(std::fs::File::create(path)?); | ||
| let src = serde_json::from_reader(reader)?; | ||
| return Ok(src) |
|
FYI @onbjerg this had seemed to work but I never tested it. May want to take it over so we don't hit rate limits when tracing with https://github.com/gakonst/foundry/tree/onbjerg/etherscan-identifier or https://github.com/gakonst/foundry/tree/etherscan-identifier-v2 |
This was referenced Apr 4, 2022
|
Took over in #1108, there is some missing stuff |
|
Ack |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, will be useful for avoidign rate limiting when doing mainnet forking in foundry and fetching ABIs/sources for tracing