This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Feat/add call deployer #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is now possible to dry run a contract deployment.
|
Looks like something's wrong with this test, I don't understand what's causing it, seems unrelated to me. |
|
It's unrelated, merged, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As it can be useful, for plentiful reasons, to perform one or several dry test runs of a contract's deployment, I hereby propose an implementation of
.call()for theDeployerstruct.Solution
The implementation is straightforward, as it consist in invoking the client's
.call()method from theMiddlewaretrait to simulate the deployment. Such doing leaves plenty of room to handle reverts in a more structured way in the future.PR Checklist