This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this PR is to integrate CCIP-read and wildcard resolution functionalities into the ether-rs.
CCIP-read (Chain Agnostic Communication Interface Protocol for reading data) is a protocol designed to standardize cross-chain data reading, enabling communication and interoperability between various blockchain platforms and/or offchain.
EIP-2544 (Wildcard Resolution) adds wildcard support for (ENS) subdomains to enable more flexible name resolution and advanced resolver creation without modifying existing contracts or resolvers. This change is backwards-compatible and does not affect the resolution of existing ENS records.
Solution
Both
CCIP-Read
andWildcard Resolution
features are in working condition at the time of creating this PR. However I would be happy to get feedback, regarding implementation details.There are few things left unfinished, like
validate_resolver
function. I had to disable the check, due to how CCIP-Read works with unhandled interfaces. One option may be keeping the check ifwildcard resolution
support is not available (not really sure though, I will be checking).PR Checklist