This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(abigen): pin bindings to latest crate version #2272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this still generate a binding that depends on git if there's another crate around? Should we make |
mattsse
reviewed
Mar 16, 2023
Comment on lines
+16
to
+20
| const DEFAULT_ETHERS_DEP: &str = concat!( | ||
| "ethers = { version = \"", | ||
| env!("CARGO_PKG_VERSION"), | ||
| "\", default-features = false, features = [\"abigen\"] }" | ||
| ); |
There was a problem hiding this comment.
this will cause issues with foundry because foundry uses ethers master to generate bindings that then depend on crates.
so until we use ethers from crates in foundry, I recommend against this.
There was a problem hiding this comment.
makes sense, closing until then
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
refs #2271
we should be switching off of git deps for downstream too anyway
Solution
PR Checklist