This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat: deseralize other fields on tx receipts #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to
TransactionandBlock, L2s (particularly Optimism) have custom fields onTransactionReceipt. These fields may be necessary in determining the gas cost of a transaction.Solution
Simply added
other: OtherFieldstoTransactionReceipt, same as existing usage onTransaction. I've also confirmed this works on Optimism's custom params.Please let me know if there was a reason this type was skipped in the initial roll out of
OtherFieldsPR Checklist