ci/test: improve CI jobs and tests #2189

DaniPopes · 2023-02-24T19:47:46Z

Motivation

Closes #1991
Closes #1978

Solution

TODO

Not planned for this PR (#2191):

Feature checks: another PR because it requires massive feature changes. see: https://github.com/gakonst/ethers-rs/actions/runs/4266867552/jobs/7427873846
WASM: same as feature checks. Doesn't work with --all-features because of tokio: https://github.com/gakonst/ethers-rs/actions/runs/4267048448/jobs/7428242514

PR Checklist

Added Tests
Added Documentation
Updated the changelog
Breaking changes

DaniPopes · 2023-02-28T01:45:55Z

@gakonst ready for review 🙏

Remaining failing actions:

deny (licenses): will open an issue later / tomorrow
windows: I have no clue what is wrong... It fails to compile a random example every time, which I cannot reproduce on my own machine, might be because of cache? Is there a way to clear that?
examples: fixed by fix: examples #2207

prestwich · 2023-02-28T02:07:44Z

.github/scripts/install_test_binaries.sh

+
+# Installs geth from https://geth.ethereum.org/downloads
+install_geth() {
+    case "$PLATFORM" in


is it worth caching and then shortcutting if tool is already installed?

hmm, would need to check version in case they differ, but we're only downloading binary so it's not that important imo

prestwich · 2023-02-28T02:20:05Z

ethers-contract/ethers-contract-abigen/src/contract/events.rs

-    use ethers_core::abi::{EventParam, Hash, ParamType};
-    use proc_macro2::Literal;
-
-    /// Expands a 256-bit `Hash` into a literal representation that can be used with


is this going somewhere? is dead code?

I couldn't understand it; it's a local function in the test module, so it's not used anywhere else and had a test.. it doesn't really do anything

prestwich · 2023-02-28T02:22:04Z

ethers-contract/ethers-contract-abigen/src/source/mod.rs

-        assert_eq!(Source::parse(abs).unwrap(), exp);
-        assert_eq!(Source::parse(abs_url).unwrap(), exp);
+        // Skip checking paths on Windows
+        #[cfg(not(windows))]


should this be re-written to use std::path instead of strings?

Realized that the diff was just the weird windows canonicalize thing, so dunce::canonicalize fixes that

prestwich · 2023-02-28T02:25:54Z

ethers-contract/tests/it/contract.rs

@@ -1,951 +1,927 @@
-#![allow(unused)]
+use crate::common::*;


this is a big diff. I'm guessing git is over-reporting a file rearrangement? can you summarize changes?

It's 99% indentation, it contained only one module so I extracted that

prestwich · 2023-02-28T02:26:13Z

ethers-contract/tests/it/contract_call.rs

-#[tokio::test]
-async fn contract_call_into_future_is_send() {
-    abigen!(DsProxyFactory, "ethers-middleware/contracts/DsProxyFactory.json");
+fn _contract_call_into_future_is_send() {


now unused?

Just a compilation test

prestwich · 2023-02-28T02:30:01Z

ethers-core/src/utils/geth.rs

        // geth uses stderr for its logs
        cmd.stderr(Stdio::piped());
+
+        let mut unused_ports = unused_ports::<3>().into_iter();


this is good

gakonst

This all looks great to me. Would love if we can double click on why any of the new tests are failing, and if we ultimately think it's OK I'm down to track in a new issue and @DaniPopes can handle the next steps?

gakonst · 2023-02-28T02:12:59Z

.github/scripts/install_test_binaries.sh

+    chmod +x "solc$EXT"
+}
+
+main


gakonst · 2023-02-28T02:13:15Z

.github/workflows/audit-on-push.yml

@@ -1,14 +0,0 @@
-name: Security audit


I think we want to keep this. Any reason not to?

see deps.yml file, changed to use the one reth uses

gakonst · 2023-02-28T02:15:08Z

ethers-contract/ethers-contract-abigen/src/contract/events.rs

-
-    #[test]
-    #[rustfmt::skip]
-    fn expand_hash_value() {


was this unused?

yes #2189 (comment)

gakonst · 2023-02-28T02:18:35Z

ethers-core/src/types/transaction/eip2930.rs

@@ -95,6 +95,7 @@ pub enum Eip2930RequestError {
 pub struct Eip2930TransactionRequest {
    #[serde(flatten)]
    pub tx: TransactionRequest,
+    #[serde(rename = "accessList")]


Yikes. @prestwich lol how was this never caught before, I guess nobody ever used direct 2930, and we do camelCase all in 1559 for access lists

gakonst · 2023-02-28T02:19:48Z

ethers-core/src/utils/geth.rs

@@ -427,7 +433,7 @@ impl Geth {
            serde_json::to_writer_pretty(&mut file, &genesis)
                .expect("could not write genesis to file");

-            let mut init_cmd = Command::new(GETH);
+            let mut init_cmd = Command::new(bin_path);


gakonst · 2023-02-28T02:21:01Z

ethers-etherscan/tests/it/main.rs

@@ -0,0 +1,76 @@
+//! Etherscan integration tests


Love that we're leaning on thetests/it/main.rs pattern to save time compiling

gakonst · 2023-02-28T02:24:00Z

ethers-middleware/tests/it/gas_escalator.rs

+use ethers_signers::{LocalWallet, Signer};
+
+#[tokio::test]
+#[ignore]


cc @prestwich who's worked on the gas escalators before.

What is the current issue you're facing?

ethers-middleware/tests/it/wallets.rs

gakonst · 2023-02-28T08:08:34Z

ethers-middleware/tests/it/transformer.rs

+abigen!(SimpleStorage, "../tests/testdata/SimpleStorage.json");
+
+#[tokio::test]
+#[ignore]


https://github.com/dapphub/ds-proxy we should understand why it's failing

gakonst · 2023-02-28T08:10:24Z

.github/workflows/ci.yml

+            - name: live tests
+              run: cargo test -p ethers --test live --all-features
+
+    # TODO: [#2191](https://github.com/gakonst/ethers-rs/issues/2191)


sgtm - we can do as followup

gakonst · 2023-03-01T00:26:11Z

OK. send it

DaniPopes · 2023-03-01T00:30:11Z

🫡

DaniPopes added 3 commits February 24, 2023 18:42

ci: move to scripts directory

70f3b83

nits

f7963d0

ci: improve main CI jobs

50a4b2a

DaniPopes marked this pull request as draft February 24, 2023 19:48

DaniPopes added 26 commits February 24, 2023 20:51

fix: install script

f805e8a

fix

362de60

fix: use curl for windows installation

8ae67b4

fix: wasm typo

0d14b4c

tests: move to single binary

5f2de7b

chore: clippy

376b8ce

chore: clippy

9e33478

chore: clippy

f8696c2

fix: test command

dcd1ef2

fix: quote tests

e06fcd4

update script

7a88c65

fix: action exclude

49c7b24

fix: dev deps

017db8b

fix: only run wasm in own job

8c0cb71

ci: add aarch64 targets

75f63f9

test: rm useless test

5f32e98

ci: update security audit

2187353

ci: add deny CI

4cee892

chore: rm unused audit.toml

5ca9864

chore: update geth.rs

e0e7876

ci: remove unusable targets

504b77c

fix: install script path

f7e02ba

fix: wasm

5a1d97a

improve script

3d4820d

Merge branch 'master' into ci/improve

c3748e9

fix: failing ci

58ce0e1

DaniPopes added 15 commits February 27, 2023 18:51

fix: abi online source test

399b7ef

fix: windows paths in test

314bbef

chore: update serial_test

1729001

ci: run live tests separately

cdd9d84

fix: provider tests

7595146

Merge branch 'master' into ci/improve

5d319d5

fix: unused var

d934e16

fix: feature

2b07891

fix merge

ee30fda

fix: etherscan key tests

b55423c

ci: rm duplicate audit

0714817

fix: split etherscan test ci

d78c2f1

Merge branch 'master' into ci/improve

8536eae

fix: etherscan test

b1d7c47

fix: generate multiple unused ports

8c06409

DaniPopes marked this pull request as ready for review February 28, 2023 01:08

Merge branch 'master' into ci/improve

5aea513

prestwich reviewed Feb 28, 2023

View reviewed changes

fix: source test

70a8aa7

gakonst approved these changes Feb 28, 2023

View reviewed changes

DaniPopes added 2 commits February 28, 2023 15:18

fix: udeps

990c178

rm unused

afbb71e

gakonst merged commit da743fc into gakonst:master Mar 1, 2023

DaniPopes deleted the ci/improve branch March 1, 2023 00:30

This was referenced Mar 1, 2023

Fix gas escalator integration test #2211

Closed

Fix transformer middleware integration test #2213

Closed

mattsse mentioned this pull request Jun 14, 2023

refactor: replace unused ports with unused port #2475

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci/test: improve CI jobs and tests #2189

ci/test: improve CI jobs and tests #2189

DaniPopes commented Feb 24, 2023 •

edited

Loading

DaniPopes commented Feb 28, 2023 •

edited

Loading

prestwich Feb 28, 2023

DaniPopes Feb 28, 2023

prestwich Feb 28, 2023

DaniPopes Feb 28, 2023

prestwich Feb 28, 2023

DaniPopes Feb 28, 2023

prestwich Feb 28, 2023

DaniPopes Feb 28, 2023 •

edited

Loading

prestwich Feb 28, 2023

DaniPopes Feb 28, 2023

prestwich Feb 28, 2023

gakonst left a comment

gakonst Feb 28, 2023

gakonst Feb 28, 2023

DaniPopes Feb 28, 2023 •

edited

Loading

gakonst Feb 28, 2023

DaniPopes Feb 28, 2023

gakonst Feb 28, 2023

gakonst Feb 28, 2023

gakonst Feb 28, 2023

gakonst Feb 28, 2023

gakonst Feb 28, 2023

gakonst Feb 28, 2023

gakonst commented Mar 1, 2023

DaniPopes commented Mar 1, 2023

ci/test: improve CI jobs and tests #2189

ci/test: improve CI jobs and tests #2189

Conversation

DaniPopes commented Feb 24, 2023 • edited Loading

Motivation

Solution

TODO

PR Checklist

DaniPopes commented Feb 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DaniPopes Feb 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gakonst left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DaniPopes Feb 28, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gakonst commented Mar 1, 2023

DaniPopes commented Mar 1, 2023

DaniPopes commented Feb 24, 2023 •

edited

Loading

DaniPopes commented Feb 28, 2023 •

edited

Loading

DaniPopes Feb 28, 2023 •

edited

Loading

DaniPopes Feb 28, 2023 •

edited

Loading