This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(core): expose genesis and private key in Geth #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* expose the genesis and clique_private_key fields in GethInstance * add tests which initialize geth with clique_private_key, making sure the genesis and clique_private_key fields are exposed on the GethInstance
Rjected
force-pushed
the
expose-genesis
branch
from
25bb3cd to
4374aab
Compare
18 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While the
genesisandclique_private_keyfields are exposed inGeth, they can't be accessed once theGethInstanceis spawned.Solution
This exposes the
genesisandclique_private_keyfields inGethInstance.PR Checklist