This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix(core): decode to correctly in Transaction #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* would not correctly decode a create transaction because 0x80 was not properly decoded
gakonst
approved these changes
Dec 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently
Transactions do not decode correctly if they are contract creation transactions. This is when thetofield isNone, which is encoded in RLP as0x80.Solution
Refactor the
decode_tomethod to instead returnResult<Option<Address>, DecodeError>, and use it when decodingTransactions, not just transaction requests.Add a test from #1393 that passes with the changes.
Fixes #1939
PR Checklist