Skip to content
This repository has been archived by the owner on Oct 19, 2024. It is now read-only.

fix(eip712): improve argument parsing #1485

Merged
merged 4 commits into from
Jul 20, 2022
Merged

fix(eip712): improve argument parsing #1485

merged 4 commits into from
Jul 20, 2022

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 19, 2022

Motivation

Closes #1484

Solution

  • use Option for attribute parsing
  • use reexported hex in generated code
  • reexport serde_json and use in generated code

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit a958b4f into gakonst:master Jul 20, 2022
@the-emerald the-emerald mentioned this pull request Jul 29, 2022
Closed
@mattsse mattsse mentioned this pull request Aug 18, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ethers-derive-eip712 impossible to use
2 participants
@mattsse @gakonst