This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
feat(solc): emit artifacts for standalone source files #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
May 22, 2022
mattsse
added a commit
to mattsse/ethers-rs
that referenced
this pull request
May 28, 2022
* feat(solc): emit artifact files for sources with no contracts * test(solc): add tests for emitting standalone sources * chore: update CHANGELOG * style: check ast is some
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
standalone sources don't contain any ContractDefinition (contract, lib, interface) and solc only includes those files in the
sourceslist of its output.However the ast of these files is still valuable for other tools such as slither See foundry-rs/foundry#1646
so we need to also generate an artifact for those.
Solution
We keep track of all source files that we could attribute to a Contract. if a source file was not referenced by a contract and the ast is not empty and does not include any
ContractDefinitionwe also generate a basic artifact that only includes the id and astcc @mds1 @montyly
PR Checklist