This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
Fix: Change VMOperation
's op
field type to ensure future proof
#1902
Labels
bug
Something isn't working
Version
ethers 1.0.0
Description
The pull request #1858 addressing issue #1857 was implemented using a unstable design pattern that will cause issues in the future. A better approach would be to make the
op
field inVMOperation
of type String instead of the newly introduced enumOpCode
.Making this change solves the following potential issues:
KECCAK256
whilst opcode 0x20 on erigon use to be calledSHA3
until very recently where 0x20 was renamed to KECCAK256)ethers::core::types::OpCode
will need to be updated to reflect this. Otherwise existing applications will panic whenever aVmTrace
is requested as it won't be able to deserialize and parse the new opcodes from the trace.The text was updated successfully, but these errors were encountered: