-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add outputPath as plugin option, override conditional checks #38
base: master
Are you sure you want to change the base?
Conversation
Ah - the newest version of this plugin only supports webpack |
if (_.has(compiler, 'options.output.path') && compiler.options.output.path !== '/') { | ||
outputPath = compiler.options.output.path; | ||
if (options.outputPath) { | ||
outputPath = options.outputPath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this will cause the plugin to fail if no outputPath
option is specified (see the check below this). For backwards compatibility it may want to fall back to the original output.path
of the compiler.
This would be a very helpful addition for us, as we organize different types of resulting bundles into sub-directories under the root Webpack |
Is this still relevant? |
If the conflicts are resolved, I will merge it. |
This plugin seems to be a little broken?
This PR lets the sandbox work with
[email protected]
+[email protected]
.I don't think this PR should necessarily be merged as it changes the API but I'm just highlighting the problem and a potential solution.
Additional Details
In webpack 1.x
I couldn't get the sandbox to work with
[email protected]
+[email protected]
due to it throwing:In webpack 2.x
I couldn't get the sandbox to work with
[email protected]
+[email protected]
due to it throwing:There's clearly been a API change in webpack 2.x since the beta 😄 .