Optionally loosen requireParam when implements/augments/extends present on tag or parent
#116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and `allowAugmentsExtendsWithoutParam` and apply to `requireParam` (fixes gajus#100)
gajus
requested changes
Dec 7, 2018
|
|
||
| const checkJsdoc = (functionNode) => { | ||
| const jsdocNode = sourceCode.getJSDocComment(functionNode); | ||
|
|
||
| if (!jsdocNode) { | ||
| return; | ||
| } | ||
| const ancestors = context.getAncestors(); |
There was a problem hiding this comment.
style: add a space before ancestors.
There was a problem hiding this comment.
I guess you mean a line break, right? It's at the right indent...
…tParam` options to include methods whose class has the tag instead (i.e., @OverRide, @implements, @Augments, or @extends)
brettz9
force-pushed
the
without-param
branch
from
bddb347 to
d60d5be
Compare
|
I've amended to address the styling issues... |
|
🎉 |
|
🎉 This PR is included in version 3.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure whether to add them as settings rather than rule-specific options, but I followed your pattern.