Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDRSPS-1144 Re-usable Sites schema and validation changes #380

Merged
merged 8 commits into from
Jan 13, 2025

Conversation

Lincoln-GR
Copy link
Contributor

@Lincoln-GR Lincoln-GR commented Jan 13, 2025

In general this PR ensures all SSD templates have all the fields siteID, siteIDSource and existingBDRSiteIRI.
These are the "site ID-related" fields. They are all used to identify a Site.
Either by the combination of siteID+siteIDSource, or by just existingBDRSiteIRI.

A Site should be consistently identified the same way across all the templates in a submission.

The PR can be viewed 1 commit at a time;

  • first 2 commits: Add new plugins to used for validation.
  • next 3 commits: Add new field(s) to each template, and update validation of the site fields for each template.
  • next 3 commits: Update existing cross-validations to work with the new fields.

@Lincoln-GR Lincoln-GR force-pushed the BDRSPS-1144-resusable-sites branch from bb4580f to 184c847 Compare January 13, 2025 03:49
@Lincoln-GR Lincoln-GR force-pushed the BDRSPS-1144-resusable-sites branch from 184c847 to ea94e02 Compare January 13, 2025 03:59
…date validation of the siteID/siteIDSource fields

Now each site must be identified by a unique siteID+siteIDSource combo, or by an existingBDRSiteIRI
…ce data template and update validation of the site-related fields

Now each occurrence can identify its site by either siteID+siteIDSource combo, or by existingBDRSiteIRI
…and update validation of the site-related fields

Now each visit must identify its site by either siteID+siteIDSource combo, or by existingBDRSiteIRI
To work with the new re-usable sites fields siteID, siteIDSource and existingBDRSiteIRI
…e new existingBDRSiteIRI field.

If a Site has a existingBDRSiteIRI in the site template, Occurrences must reference it by that to use its location,
Or they must use siteID+siteIDSource, or they must have their own location.
…ence file to work with existingBDRSiteIRI field.

If a Site has a existingBDRSiteIRI in the site template, Occurrences must reference it by that to use its location,
Or they must use siteID+siteIDSource, or they must have their own location.
@Lincoln-GR Lincoln-GR force-pushed the BDRSPS-1144-resusable-sites branch from ea94e02 to 3232e0a Compare January 13, 2025 04:05
@Lincoln-GR Lincoln-GR marked this pull request as ready for review January 13, 2025 04:08
@chungvl chungvl merged commit 107a014 into main Jan 13, 2025
10 checks passed
@chungvl chungvl deleted the BDRSPS-1144-resusable-sites branch January 13, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants