BDRSPS-1127 Add import linter to check program structure #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps import-linter work better. It is also recommended by pytest for test packages (https://docs.pytest.org/en/stable/explanation/pythonpath.html#import-modes) when using `prepend` import mode (the default).
Update them to not use paths relying on the current working directory.
Because it is not a fixture, it does not belong in conftest.py
Lincoln-GR
force-pushed
the
BDRSPS-1127-import-linter
branch
from
d4385fa to
e30f01a
Compare
chungvl
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import rules ("contracts") I've set up to start with are basically:
I've also taken this opportunity to simplify the dynamic template imports with regular imports.
The dynamic imports where more complex than required and import-linter could not check them.