BDRSPS-1088 Swap schema:identifier for schema:name for attribute Collections
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lincoln-GR
force-pushed
the
BDRSPS-1088
branch
from
9959c1f to
9cc58b1
Compare
Typically, when one fails, the others are at least 90% done, so there isn't much saving in failing fast. I would rather see if the failure is for all py versions or just some.
chungvl
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap predicate as per feedback.
I also tweaked the python matrix test logic.
Typically, when one fails, the others are at least 90% done, so there isn't much saving in failing fast.
I would rather see if the failure is for all py versions or just some.