BDRSPS-1068 Add custom string field to treat whitespace-only cells as empty #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Should update |
joecrowleygaia
approved these changes
Nov 28, 2024
Comment on lines
+96
to
+106
| ## Frictionless | ||
|
|
||
| The project uses the [Frictionless Framework](https://framework.frictionlessdata.io/) to validate and read the | ||
| template CSV files. | ||
| We have a number of plugins defined in the [`/abis_mapping/plugins`](/abis_mapping/plugins) directory which | ||
| customize and extend how Frictionless works. | ||
|
|
||
| ### Overridden String Field Class | ||
|
|
||
| In particular, we have the [`abis_mapping/plugins/string_customized.py`](/abis_mapping/plugins/string_customized.py) | ||
| plugin which overrides the default Frictionless string field to use our custom class. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This custom field is set to override the default frictionless string field.
It converts whitespace-only cells to the empty string before the regular frictionless validation/checks occur.
This means that
Nonewhen mapping, when their cell is whitespace-only (i.e. behave the same as an empty cell)