BDRSPS-1028 Created specific relatedSiteID custom check and applied to site data template v2 #348
Conversation
…lied that to the validation of relatedSiteID on the site template.
…ied it to the validation of survey site data template.
| """ | ||
| check = ( | ||
| row["relatedSiteID"] in self.site_ids | ||
| if row["relatedSiteID"] and row["relationshipToRelatedSite"].lower().replace(" ", "") == "partof" |
There was a problem hiding this comment.
rather than
row["relationshipToRelatedSite"].lower().replace(" ", "") == "partof"you could use
vocabs.relationship_to_related_site.PART_OF.match(row["relationshipToRelatedSite"])in a similar fashion to here so we don't have another implmentation of matching a value to the vocab
There was a problem hiding this comment.
intentionally went this way since it is related to validation and not to mapping, i.e. in the same vane we duplicate enums for fields that map to restricted vocabs in the schema. I am concerned with a bad code smell of adding the vocab dependency to a frictionless plugin module. It may not create a complete circular import but it would be one step away. The example provided was for a mapping function, contained within the module. I could move this custom check into the same module as the site data mapper to completely remove that concern for me but it might make it less readable for others.
There was a problem hiding this comment.
intentionally went this way since it is related to validation and not to mapping
ok that makes sense 👍
The check looks at the
relationshipToRelatedSiteand if found to be "partOf" then therelatedSiteIDmust be declared as asiteIDin the same template.