BDRSPS-819 Made necessary tests or changes to types code after investigating low coverage on tests. #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably the biggest change is no longer returning None when retrieving datum uris. The thought here is that previously when these were directly retrieved from within the mapping methods, that there were no protections against the vocab error that would be thrown as well as the fact that the data that is expected to hit this method is already expected to have been validated through the enum check of the
geodeticDatumfields. A chained exception is raised in its place.Also renamed non-uppercase comment "note" with "NOTE" to help IDEs identify better.