Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDRSPS-966: Part1: Update IRIs appearing in survey metadata v2 RDF #304

Merged
merged 8 commits into from
Nov 8, 2024
Merged

BDRSPS-966: Part1: Update IRIs appearing in survey metadata v2 RDF #304

merged 8 commits into from
Nov 8, 2024

Conversation

Lincoln-GR
Copy link
Contributor

@Lincoln-GR Lincoln-GR commented Nov 6, 2024 •
edited
Loading

Update IRIs that appear in the survey metadata v2 RDF to

  • follow the new standard.
  • Use the base_iri as their base (not the dataset)
  • Use helper functions for easy re-use.

@Lincoln-GR Lincoln-GR marked this pull request as draft November 6, 2024 04:25
@Lincoln-GR Lincoln-GR force-pushed the BDRSPS-966-survey-metadata branch from ee4c718 to 9675859 Compare November 7, 2024 06:00
@Lincoln-GR Lincoln-GR force-pushed the BDRSPS-966-survey-metadata branch from 9675859 to 07936a0 Compare November 7, 2024 06:08
@Lincoln-GR Lincoln-GR marked this pull request as ready for review November 7, 2024 06:19
joecrowleygaia
joecrowleygaia suggested changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@joecrowleygaia joecrowleygaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments for attention, the use of keyword only for survey iri and test docstring. The rest are just comments with no follow up expected.

abis_mapping/templates/survey_metadata_v2/mapping.py Show resolved Hide resolved
abis_mapping/utils/iri_patterns.py Outdated Show resolved Hide resolved
tests/utils/test_rdf.py Show resolved Hide resolved
abis_mapping/utils/iri_patterns.py Show resolved Hide resolved
abis_mapping/utils/rdf.py Show resolved Hide resolved
@joecrowleygaia joecrowleygaia merged commit fc7a6e2 into main Nov 8, 2024
7 checks passed
@joecrowleygaia joecrowleygaia deleted the BDRSPS-966-survey-metadata branch November 8, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecrowleygaia joecrowleygaia joecrowleygaia approved these changes

Assignees

@joecrowleygaia joecrowleygaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lincoln-GR @joecrowleygaia