-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BDRSPS-918] First stab adding coordinateUncertaintyInMeters
#290
Conversation
coordinateUncertaintyInMetres
coordinateUncertaintyInMetres
coordinateUncertaintyInMeters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that it is required for metadata template since the field doesn't exist.
coordinateUncertaintyInMeters
coordinateUncertaintyInMeters
coordinateUncertaintyInMeters
coordinateUncertaintyInMeters
abis_mapping/templates/incidental_occurrence_data_v3/mapping.py
Outdated
Show resolved
Hide resolved
abis_mapping/templates/incidental_occurrence_data_v3/mapping.py
Outdated
Show resolved
Hide resolved
@chungvl Can you try running the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this means there was an upgrade applied to the poetry project, or the lockfile was deleted and recreated. Does it need to be left as-was @serge-gaia or @Lincoln-GR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the sub-dependencies were bumped. This will only effect development and CI on this project, not part-a.
Should be fine to leave it. Or on the other hand no reason it needs to be in this PR 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prior to doing an update the generate-example-ttl
script wasn't working for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For next time, I would imagine just doing poetry install
to install the current dependencies, should be sufficient to get the script working without changing the lock file.
(Assuming there isn't an actual incompatibility between our code and a dependency)
No description provided.