Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BDRSPS-913 Added site visit id cross validation input to site visit template. #264

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

joecrowleygaia
Copy link
Collaborator

@joecrowleygaia joecrowleygaia commented Oct 16, 2024

Removed LogicalOr foreign key logic and added mutual inclusion whitelist logic.

[EDIT] Removed whitelist logic from mutual inclusion and had it inserted into newly created enhanced required custom checker.

…moved logical or foreign key logic and added mutual inclusion whitelist logic.
Copy link
Contributor

@Lincoln-GR Lincoln-GR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two smalll things

abis_mapping/plugins/required.py Outdated Show resolved Hide resolved
abis_mapping/plugins/mutual_inclusion.py Outdated Show resolved Hide resolved
@Lincoln-GR Lincoln-GR merged commit 4d9c9f6 into main Oct 17, 2024
6 checks passed
@Lincoln-GR Lincoln-GR deleted the BDRSPS-913 branch October 17, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants