Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDRSPS-857 Schema update for site visist data template v2 #228

Merged
merged 4 commits into from
Oct 3, 2024
Merged

BDRSPS-857 Schema update for site visist data template v2 #228

merged 4 commits into from
Oct 3, 2024

Conversation

Lincoln-GR
Copy link
Contributor

@Lincoln-GR Lincoln-GR commented Oct 3, 2024 •
edited
Loading

  • fixed bug where unique constraints in our schema files weren't getting passed to frictionless
    • added test case to site data v2 to test this
  • removed dev comment from schema
  • allow multiple siteIDs in site visit template

Lincoln-GR
Lincoln-GR commented Oct 3, 2024
View reviewed changes
abis_mapping/templates/survey_site_visit_data_v2/schema.json
"required": true,
"unique": true
"required": true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joecrowleygaia do you agree with removing unique: true from siteID? Otherwise you won't be able to have multiple visits per site in the template

@joecrowleygaia joecrowleygaia merged commit bc35171 into main Oct 3, 2024
6 checks passed
@Lincoln-GR Lincoln-GR deleted the BDRSPS-857 branch October 3, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecrowleygaia joecrowleygaia joecrowleygaia approved these changes

Assignees

@joecrowleygaia joecrowleygaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lincoln-GR @joecrowleygaia