BDRSPS-780 Implemented schema.json and new mutual inclusion check for sensitivity cat and authority #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y category and authority for survey occurrence v2 template.
Lincoln-GR
reviewed
Sep 16, 2024
| "required": false | ||
| }, | ||
| "vocabularies": [ | ||
| "SENSITIVITY_CATEGORY" |
There was a problem hiding this comment.
Is this vocab defined somewhere? or is that still in dev?
|
Not a blocking issue, but this is a great example of where I would be happy for the 2 commits to be squashed into 1 so we end up with a cleaner git history. |
Lincoln-GR
reviewed
Sep 16, 2024
| @@ -46,7 +46,7 @@ | |||
| CONCEPT_NAME_CHECK_METHOD = utils.rdf.uri("methods/name-check-method", utils.namespaces.EXAMPLE) # TODO -> Need real URI # noqa: E501 | |||
| CONCEPT_SEQUENCE = utils.rdf.uri("concept/sequence", utils.namespaces.EXAMPLE) # TODO -> Need real URI | |||
| CONCEPT_CONSERVATION_STATUS = rdflib.URIRef("http://linked.data.gov.au/def/tern-cv/1466cc29-350d-4a23-858b-3da653fd24a6") # noqa: E501 | |||
| CONCEPT_CONSERVATION_JURISDICTION = rdflib.URIRef("http://linked.data.gov.au/def/tern-cv/755b1456-b76f-4d54-8690-10e41e25c5a7") # noqa: E501 | |||
| CONCEPT_CONSERVATION_AUTHORITY = rdflib.URIRef("http://linked.data.gov.au/def/tern-cv/755b1456-b76f-4d54-8690-10e41e25c5a7") # noqa: E501 | |||
There was a problem hiding this comment.
Following the link takes you to a tern page for "conservation status jurisdiction", should we keep this as CONCEPT_CONSERVATION_JURISDICTION? I'm not a SME here
Lincoln-GR
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conservation jurisdiction vocab had a name change from CONSERVATION_JURISDICTION to CONSERVATION_AUTHORITY as part of this.