Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more flake8 and flake8-bugbear rules #200

Closed
wants to merge 6 commits into from
Closed

Enable more flake8 and flake8-bugbear rules #200

wants to merge 6 commits into from

Conversation

Lincoln-GR
Copy link
Contributor

@Lincoln-GR Lincoln-GR commented Sep 9, 2024 •
edited
Loading

  • Set flake8 ignore list (to override default ignore list) so that rules related to indentation are enabled.
  • Enable flake8-bugbear rules related to errors and best practice (not code format/style)

@Lincoln-GR
Upgrade flake8 and plugins
639edf4
@Lincoln-GR
Reduce number of ignored flake8 rules
6a4b591 
This explicit ignore list overrides the default ignore list, which is larger.
@Lincoln-GR
Fix indentation to 4 spaces
21ac15e
@Lincoln-GR
Enable some optional rules from flake8-bugbear
3ba4c4f 
IMO these are all good rules to enable
@Lincoln-GR
Chain exception correctly
a71359f
@Lincoln-GR
Add strict=True to all zip() calls
8087e1a 
This will surface bugs where the length of the iterables is not equal
@Lincoln-GR Lincoln-GR changed the title Check for warnings in tests and enable more flake8 Enable more flake8 and flake8-bugbear rules Sep 9, 2024
@Lincoln-GR Lincoln-GR closed this Oct 2, 2024
@Lincoln-GR Lincoln-GR deleted the BDRSPS-796 branch October 2, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lincoln-GR