BDRSPS-762 Create initial version of incidental template v3 #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lincoln-GR
force-pushed
the
BDRSPS-762-incidental-v3
branch
from
424edb0 to
56209da
Compare
joecrowleygaia
suggested changes
Aug 26, 2024
|
|
||
|
|
||
| # Register Mapper | ||
| base.mapper.ABISMapper.register_mapper(IncidentalOccurrenceMapper) |
There was a problem hiding this comment.
Can leave this commented out for now or behind a feature flag somehow? Maybe a conditional of when version >= 5.0.0(-rcx) ?
There was a problem hiding this comment.
@joecrowleygaia I'll put it behind a check so its only registered for unit tests?
This is entirely copied from v2, with just the version number changed to v3.0.0
This means it can be unit tested while we develop it, but not available in the app
Lincoln-GR
force-pushed
the
BDRSPS-762-incidental-v3
branch
from
56209da to
8148d5c
Compare
joecrowleygaia
approved these changes
Aug 26, 2024
Comment on lines
+3146
to
+3148
| if os.getenv("PYTEST_VERSION"): | ||
| # incidental v3 is still in development, only register for unit tests. | ||
| base.mapper.ABISMapper.register_mapper(IncidentalOccurrenceMapper) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is entirely copied from v2, with just the version number changed to v3.0.0