Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔒 : secure api state endpoint #224

Merged
merged 5 commits into from
Feb 5, 2020
Merged

🔒 : secure api state endpoint #224

merged 5 commits into from
Feb 5, 2020

Conversation

juwit
Copy link
Member

@juwit juwit commented Feb 5, 2020 •
edited
Loading

  • Securing the /api/state endpoint with basic auth.
  • Add basic auth to the generated terraform script (for the http backend)
  • Add stack and job screen to percy

This PR resolves #59

@juwit juwit requested a review from cdubuisson February 5, 2020 12:22
@juwit juwit added ✅ tests Updating tests ✨ feature:jobs Jobs ✨ feature:stacks stack list & stack edition 👤 user:end-user end-user labels Feb 5, 2020
@juwit juwit added this to the 1.3.0 milestone Feb 5, 2020
@juwit juwit force-pushed the 59-secure-api-state-endpoint branch from 718de67 to 0bf3cc5 Compare February 5, 2020 12:36
@juwit juwit added 👌 ready for review The pull request is ready for review 🔒 security Fixing security issues. labels Feb 5, 2020
@cdubuisson cdubuisson self-assigned this Feb 5, 2020
cdubuisson
cdubuisson reviewed Feb 5, 2020
View reviewed changes
src/test/java/io/codeka/gaia/e2e/SeleniumIT.java Outdated
.withScript("src/test/resources/db/20_module.js");
.withScript("src/test/resources/db/20_module.js")
.withScript("src/test/resources/db/30_stack.js")
.withScript("src/test/resources/db/41_job.js")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

41 for job and 40 for step for the order in the database scripts ? Steps should be after jobs I think considering the model.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right. It's a mistake !

@juwit juwit force-pushed the 59-secure-api-state-endpoint branch from 0bf3cc5 to 3c8981a Compare February 5, 2020 18:12
@juwit juwit requested a review from cdubuisson February 5, 2020 18:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cdubuisson cdubuisson merged commit 9f0054b into master Feb 5, 2020
@cdubuisson cdubuisson deleted the 59-secure-api-state-endpoint branch February 5, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdubuisson cdubuisson cdubuisson approved these changes

Assignees

@cdubuisson cdubuisson

Labels
✨ feature:jobs Jobs ✨ feature:stacks stack list & stack edition 👌 ready for review The pull request is ready for review 🔒 security Fixing security issues. ✅ tests Updating tests 👤 user:end-user end-user
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

🔒 : secure "/api/state" endpoint
2 participants
@juwit @cdubuisson