Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

212 remove moment duration #215

Merged
merged 5 commits into from
Jan 25, 2020
Merged

212 remove moment duration #215

merged 5 commits into from
Jan 25, 2020

Conversation

cdubuisson
Copy link
Member

@cdubuisson cdubuisson commented Jan 25, 2020 •
edited
Loading

  • remove moment-duration-format dependency
  • remove momentjs dependency
  • use vanilla to display dates and durations

Resolves #212

@cdubuisson cdubuisson added 👌 ready for review The pull request is ready for review ⬆️ dependencies Pull requests that update a dependency file ♻️ code improvement Improving code labels Jan 25, 2020
@cdubuisson cdubuisson requested a review from juwit January 25, 2020 13:15
@cdubuisson cdubuisson force-pushed the 212-remove-moment-duration branch from 76cff78 to 2d499d2 Compare January 25, 2020 13:16
@cdubuisson cdubuisson mentioned this pull request Jan 25, 2020
Closed
@juwit juwit self-assigned this Jan 25, 2020
@juwit juwit added this to the 1.3.0 milestone Jan 25, 2020
@cdubuisson cdubuisson force-pushed the 212-remove-moment-duration branch from 2d499d2 to baa754c Compare January 25, 2020 14:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@juwit juwit self-requested a review January 25, 2020 14:49
@cdubuisson cdubuisson requested a review from juwit January 25, 2020 14:50
@juwit juwit merged commit 47a28fa into master Jan 25, 2020
@juwit juwit deleted the 212-remove-moment-duration branch January 25, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juwit juwit Awaiting requested review from juwit

Assignees

@juwit juwit

Labels
♻️ code improvement Improving code ⬆️ dependencies Pull requests that update a dependency file 👌 ready for review The pull request is ready for review
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

➖️ : remove moment-duration-format dependency
2 participants
@cdubuisson @juwit