-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ : rework of the job management #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdubuisson
force-pushed
the
62-job-details
branch
10 times, most recently
from
August 26, 2019 07:48
a40af69
to
597de88
Compare
cdubuisson
changed the title
🚧 : rework of the job management
🚧 : rework of the job management
Aug 26, 2019
cdubuisson
force-pushed
the
62-job-details
branch
12 times, most recently
from
August 30, 2019 15:44
2b21363
to
db27048
Compare
cdubuisson
changed the title
🚧 : rework of the job management
♻️ : rework of the job management
Aug 30, 2019
cdubuisson
changed the title
♻️ : rework of the job management
♻️ : rework of the job management
Aug 30, 2019
cdubuisson
added
✨ enhancement
New feature or request
👌 ready for review
The pull request is ready for review
labels
Aug 30, 2019
juwit
requested changes
Aug 30, 2019
src/test/java/io/codeka/gaia/stacks/repository/StepRepositoryIT.java
Outdated
Show resolved
Hide resolved
cdubuisson
force-pushed
the
62-job-details
branch
from
August 30, 2019 16:49
db27048
to
fb58bed
Compare
juwit
requested changes
Aug 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've encountered an exception when starting a new stack :
Whitelabel Error Page
This application has no explicit mapping for /error, so you are seeing this as a fallback.
Fri Aug 30 18:52:05 CEST 2019
There was an unexpected error (type=Bad Request, status=400).
Failed to convert value of type 'java.lang.String' to required type 'io.codeka.gaia.stacks.bo.JobType'; nested exception is org.springframework.core.convert.ConversionFailedException: Failed to convert from type [java.lang.String] to type [@org.springframework.web.bind.annotation.PathVariable io.codeka.gaia.stacks.bo.JobType] for value 'apply'; nested exception is java.lang.IllegalArgumentException: No enum constant io.codeka.gaia.stacks.bo.JobType.apply
org.springframework.web.method.annotation.MethodArgumentTypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'io.codeka.gaia.stacks.bo.JobType'; nested exception is org.springframework.core.convert.ConversionFailedException: Failed to convert from type [java.lang.String] to type [@org.springframework.web.bind.annotation.PathVariable io.codeka.gaia.stacks.bo.JobType] for value 'apply'; nested exception is java.lang.IllegalArgumentException: No enum constant io.codeka.gaia.stacks.bo.JobType.apply
Maybe we should also duplicate the 500 error page to the 400 :)
I believe the error comes from here :
new_stack.js line222
function run(){
// save the stack & run job
$.ajax({
url: `/api/stacks`,
data: JSON.stringify(this.stack),
contentType: "application/json",
method: "POST"
}).then(saved => {
this.stack = saved;
window.location = `/stacks/${this.stack.id}/apply`;
})
}
juwit
approved these changes
Aug 30, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.