Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ : rework of the job management #127

Merged
merged 8 commits into from
Aug 30, 2019
Merged

♻️ : rework of the job management #127

merged 8 commits into from
Aug 30, 2019

Conversation

cdubuisson
Copy link
Member

No description provided.

@cdubuisson cdubuisson force-pushed the 62-job-details branch 10 times, most recently from a40af69 to 597de88 Compare August 26, 2019 07:48
@cdubuisson cdubuisson changed the title 🚧 : rework of the job management 🚧 : rework of the job management Aug 26, 2019
@cdubuisson cdubuisson force-pushed the 62-job-details branch 12 times, most recently from 2b21363 to db27048 Compare August 30, 2019 15:44
@cdubuisson cdubuisson changed the title 🚧 : rework of the job management ♻️ : rework of the job management Aug 30, 2019
@cdubuisson cdubuisson changed the title ♻️ : rework of the job management ♻️ : rework of the job management Aug 30, 2019
@cdubuisson cdubuisson requested a review from juwit August 30, 2019 15:47
@cdubuisson cdubuisson added ✨ enhancement New feature or request 👌 ready for review The pull request is ready for review labels Aug 30, 2019
@cdubuisson cdubuisson added this to the 1.2.0 milestone Aug 30, 2019
@juwit juwit self-assigned this Aug 30, 2019
Copy link
Member

@juwit juwit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've encountered an exception when starting a new stack :

Whitelabel Error Page

This application has no explicit mapping for /error, so you are seeing this as a fallback.
Fri Aug 30 18:52:05 CEST 2019
There was an unexpected error (type=Bad Request, status=400).
Failed to convert value of type 'java.lang.String' to required type 'io.codeka.gaia.stacks.bo.JobType'; nested exception is org.springframework.core.convert.ConversionFailedException: Failed to convert from type [java.lang.String] to type [@org.springframework.web.bind.annotation.PathVariable io.codeka.gaia.stacks.bo.JobType] for value 'apply'; nested exception is java.lang.IllegalArgumentException: No enum constant io.codeka.gaia.stacks.bo.JobType.apply
org.springframework.web.method.annotation.MethodArgumentTypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'io.codeka.gaia.stacks.bo.JobType'; nested exception is org.springframework.core.convert.ConversionFailedException: Failed to convert from type [java.lang.String] to type [@org.springframework.web.bind.annotation.PathVariable io.codeka.gaia.stacks.bo.JobType] for value 'apply'; nested exception is java.lang.IllegalArgumentException: No enum constant io.codeka.gaia.stacks.bo.JobType.apply

Maybe we should also duplicate the 500 error page to the 400 :)

I believe the error comes from here :

new_stack.js line222

function run(){
    // save the stack & run job
    $.ajax({
        url: `/api/stacks`,
        data: JSON.stringify(this.stack),
        contentType: "application/json",
        method: "POST"
    }).then(saved => {
        this.stack = saved;
        window.location = `/stacks/${this.stack.id}/apply`;
    })
}

@juwit juwit merged commit e7fd764 into master Aug 30, 2019
@juwit juwit mentioned this pull request Aug 30, 2019
@juwit juwit deleted the 62-job-details branch August 30, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request 👌 ready for review The pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants