Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility PR for node 12 #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

renanccastro
Copy link

@renanccastro renanccastro commented Jan 31, 2020

Please, disregard the changes to the package.json name, if you want it merged I can change it back :)

This PR makes this lib compatible with node 12, based on the libxmljs original PR.

There is also work from @alexdee2007 fork, so also thanks!

Thanks for the good work!!

@sclarson
Copy link

sclarson commented Dec 9, 2020

Any chance you want to update this for Node 14 compatibility?

@andreafalzetti
Copy link

Any update on this? Does this lib work with Node 12?

@renanccastro
Copy link
Author

Seems like the author is not active anymore.
But, my fork is working with node 12. it's published on npm too.

@sclarson I do have plans to have node 14 compatibility. Should be done in the following months.

@lognaturel
Copy link

lognaturel commented Jun 9, 2021

Thanks for this, @renanccastro! I take it this is what was released at https://www.npmjs.com/package/node1-libxmljsmt, is that right?

You may have seen me asking related questions at albanm/node-libxslt#83. Thanks for pushing both of these libraries forward. Are you still considering an update for newer Node versions? Or perhaps you'd be able to give some guidance for others who might be interested in looking further into this but are unfamiliar with the tooling?

It looks like both libraries use https://github.com/nodejs/nan which should hopefully make most of the changes to support Node 14 pretty mechanical, does that sound right? Any advice on strategy would be appreciated. As far as I can tell, Node 16 support may require a NAN upgrade to provide V8 9.0 support (nodejs/nan#910).

@rchipka
Copy link

rchipka commented Jun 10, 2021

Multi-threading, Node 12+, and Typescript types are all coming to the main repo.

Last thing remaining is further fine-tuning the new refcounting strategy to remove any leaks or segfaults.

@lognaturel
Copy link

Thanks so much, @rchipka, that looks like a very exciting overhaul indeed!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants